Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

v0.9.12-rc2 #4108

Merged
merged 4 commits into from
Oct 21, 2021
Merged

v0.9.12-rc2 #4108

merged 4 commits into from
Oct 21, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Oct 19, 2021 •
edited
Loading

@s3krit s3krit added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 19, 2021
@s3krit s3krit self-assigned this Oct 19, 2021
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Oct 19, 2021
s3krit and others added 2 commits October 19, 2021 21:53
@s3krit
bump substrate
fe489a1
@s3krit @bkchr
Remove stale migrations (#4107)
c3c8aa2 
* remove stale migrations

* fix warnings

* Update runtime/westend/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
@s3krit
Copy link
Contributor Author

s3krit commented Oct 20, 2021 •
edited
Loading

New weights will be applied when the jobs in this pipeline complete: https://gitlab.parity.io/parity/polkadot/-/pipelines/162841

@s3krit s3krit requested review from bkchr and chevdor October 20, 2021 13:50
s3krit
s3krit commented Oct 20, 2021
View reviewed changes
Copy link
Contributor Author

@s3krit s3krit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files with notable weight changes marked

runtime/westend/src/weights/pallet_vesting.rs
@@ -42,69 +44,97 @@ use sp_std::marker::PhantomData;
/// Weight functions for `pallet_vesting`.
pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> pallet_vesting::WeightInfo for WeightInfo<T> {
fn vest_locked(l: u32, s: u32) -> Weight {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes

runtime/westend/src/weights/pallet_utility.rs
@@ -42,17 +44,17 @@ use sp_std::marker::PhantomData;
/// Weight functions for `pallet_utility`.
pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> pallet_utility::WeightInfo for WeightInfo<T> {
fn batch(c: u32) -> Weight {
(15_136_000 as Weight)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The batch and batch_all in every pallet seem to have a consistent upward, especially trend per input but this is def the biggest

runtime/polkadot/src/weights/pallet_vesting.rs
@@ -42,68 +44,96 @@ use sp_std::marker::PhantomData;
/// Weight functions for `pallet_vesting`.
pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> pallet_vesting::WeightInfo for WeightInfo<T> {
fn vest_locked(l: u32, s: u32) -> Weight {
(93_789_000 as Weight)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weights for this whole pallet fairly consistently change. It looks like all the weights are more sensitive to inputs and have lower base weights. Not sure what to make of it

runtime/kusama/src/weights/runtime_common_slots.rs
fn force_lease() -> Weight {
(92_502_000 as Weight)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one's more fishy

Copy link
Contributor Author

@s3krit s3krit Oct 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running the benchmarks for runtime_common::slots manually to see if we get the same result again

runtime/kusama/src/weights/pallet_vesting.rs
@@ -42,69 +44,97 @@ use sp_std::marker::PhantomData;
/// Weight functions for `pallet_vesting`.
pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> pallet_vesting::WeightInfo for WeightInfo<T> {
fn vest_locked(l: u32, s: u32) -> Weight {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sen these before in other pallets sometimes. The base is reduced, a component is increased. Ideally the benchmark values could be tweaked to not behave like this, but suppressing that in favour of time, I usually assume this specific patter as "it is fine"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw seems like vesting consistently changed across runtimes

@s3krit
Copy link
Contributor Author

s3krit commented Oct 20, 2021

/benchmark runtime kusama runtime_common_slots

@parity-benchapp
Copy link

parity-benchapp bot commented Oct 20, 2021 •
edited
Loading

Error running benchmark: mp-v0.9.12-rc2

stdoutFrom https://github.com/paritytech/polkadot * branch master -> FETCH_HEAD bea3def..666e67d master -> origin/master

@emostov
Copy link
Contributor

emostov commented Oct 20, 2021

/benchmark runtime kusama runtime_common_slots

@parity-benchapp
Copy link

parity-benchapp bot commented Oct 21, 2021 •
edited
Loading

Error running benchmark: mp-v0.9.12-rc2

stdoutFrom https://github.com/paritytech/polkadot * branch master -> FETCH_HEAD

@s3krit
Copy link
Contributor Author

s3krit commented Oct 21, 2021 •
edited
Loading

I'm unsure how to proceed with the changed weights... my feeling is to create followup issues to track whether the weight changes are 'organic' or rather an issue with the benchmarking setup (though I feel it is the former). @kianenigma @emostov do you have thoughts on this?

edit Continued discussion of the weights can be discussed in this PR: #4113

@s3krit s3krit merged commit ec34cf7 into release-v0.9.12 Oct 21, 2021
@s3krit s3krit deleted the mp-v0.9.12-rc2 branch October 21, 2021 12:20
@ghzlatarev ghzlatarev mentioned this pull request Nov 2, 2021
Merged
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emostov emostov emostov left review comments

@kianenigma kianenigma kianenigma left review comments

@bkchr bkchr Awaiting requested review from bkchr

@chevdor chevdor Awaiting requested review from chevdor

Assignees

@s3krit s3krit

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s3krit @emostov @kianenigma @rphmeier